[WebProfilerBundle] Disable Turbo for debug toolbar links #49226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
We already disable Turbolink since years (for the same reason: making sure the WebProfiler pages are always loaded through a full page load to avoid conflicts with project code). and with Symfony UX supporting Turbo, it makes sense to make it work smoothly here.
fabpot
approved these changes
Feb 4, 2023
|
Thank you @javiereguiluz. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 20, 2024
…to avoid link prefetching (davidgorges) This PR was merged into the 5.4 branch. Discussion ---------- [WebProfilerBundle] disable turbo in web profiler toolbar to avoid link prefetching | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | [symfony/ux#1520](symfony/ux#1520) | License | MIT This adds `data-turbo="false"` to the web profiler toolbar html. It [has been added already a while ago](#49226) to the mini-toolbar, and there is already the old `data-no-turbolink` attribute present. This [fixes an issue](symfony/ux#1520) with prefetching links in Turbo 8, which causes the Ajax pane to behave weirdly and can even cause unwanted logouts (via the logout link inside the security pane). Commits ------- 9750a6b [WebProfilerBundle] disable turbo in web profiler toolbar to avoid link prefetching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stof suggested this change to me. I think it makes sense to merge it in 5.4 as a bug fix because otherwise, Symfony UX Turbo could mess with the links of the Web Debug Toolbar.