Skip to content

for #49320 #49344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

for #49320 #49344

wants to merge 1 commit into from

Conversation

isdn
Copy link
Contributor

@isdn isdn commented Feb 12, 2023

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #49320
License MIT
Doc PR symfony/symfony-docs#...

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features / 5.4 or 6.2 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@isdn isdn changed the base branch from 6.3 to 6.2 February 12, 2023 13:17
@isdn isdn changed the base branch from 6.2 to 6.3 February 12, 2023 13:19
@isdn
Copy link
Contributor Author

isdn commented Feb 12, 2023

It looks like something goes wrong when I changed the branch to 6.2. Lots of other commits were displayed in this PR.
I reverted it to 6.3.

@MatTheCat
Copy link
Contributor

You have to rebase your branch on the new target when you change it.

Also it seems you’re just reverting #32573; are you sure it is the right fix?

@isdn
Copy link
Contributor Author

isdn commented Feb 13, 2023

I am sorry, it turned out that I initially used a wrong branch. I'll recreate everything with 6.2.

@isdn isdn closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System hangs when a php interpreter is executed via Process
3 participants