[DependencyInjection] Fix autowire attribute with nullable parameters #49379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
aebfb5e to
82d35a6
Compare
82d35a6 to
d1b8040
Compare
|
Wow, that was fast. Your fix looks correct. I'll test it on my codebase tomorrow to see if it fixes my issue there. Can you please look into the "Coding Standard" failure reported by fabbot? The "Exception Messages Formatting" error however is a false positive and can be ignored. |
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
68f55ba to
75af866
Compare
|
Thank you @alamirault. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix throwing exception
Cannot autowire service "%s": argument "$%s" of method "%s()" %s, you should configure its value explicitly.when parameter is nullable with null value.(sorry for pinging reviewers, switching branch trigger that)