[DependencyInjection] Allow trimming service parameters value in XML configuration files #49412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.xsd
Outdated
Show resolved
Hide resolved
1f2ea92 to
0bc9761
Compare
src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.xsd
Outdated
Show resolved
Hide resolved
35ffcde to
06b2f39
Compare
stof
requested changes
Feb 17, 2023
| @@ -258,6 +258,7 @@ | |||
| <xsd:attribute name="id" type="xsd:string" /> | |||
| <xsd:attribute name="key" type="xsd:string" /> | |||
| <xsd:attribute name="on-invalid" type="invalid_sequence" /> | |||
| <xsd:attribute name="trim" type="boolean" /> | |||
There was a problem hiding this comment.
boolean is a type that support both xsd:boolean and DIC parameters as value. This trim should not support DI parameters as it is a value used by the loader directly.
There was a problem hiding this comment.
depends whether DIC parameters work there or no.
There was a problem hiding this comment.
I tried and it doesn't work. I'll leave xsd:boolean for exclude-self as well 👍
06b2f39 to
aaf2313
Compare
nicolas-grekas
approved these changes
Feb 17, 2023
…configuration files
aaf2313 to
bdc4c10
Compare
|
Thank you @alexandre-daubois. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While coming across this documentation page, I learnt that strings as service parameters value aren't trimmed when using the XML multi-line style to define the value. I think adding the possibility of trimming the value if wanted could be a plus, allowing more flexibility when writing XML files.
Also, when using the
binaryparameter type,base64_decodeactually trims the string and allows to use the multi-line syntax. So we could see an added consistency here by allowing this with string parameters. 🙂