[PHPUnit bridge] Do not register error handler under PHPUnit 10 #49440
Conversation
|
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "5.4". Cheers! Carsonbot |
|
thanks for the work @Jean85! I hope to see this merged until the bridge can officially support PHPUnit 10 |
|
Maybe it should be changed to |
|
@temp I'm not sure, but that may be a BC break. This package is designed to work with multiple versions of phpunit, including (I believe) versions that predate that change Also, I'm struggling to find the commit/issue but I believe the symfony team made a change this year to prevent phpunit bridge from being installed alongside 10. In other words, i think they decided to implement a "fix" for this issue, but one that was less forgiving than the suggestion here for those of us who want to run phpunit 10 |
|
##49069 has been fixed meanwhile. Closing, please consider reopening if it's still relevant |
This is motivated by #49069 (comment), until #49069 is fully addressed.
What happens is that PHPUnit 10 now registers its own error handler to trap notice/warnings/deprecations and make them flow through its new event system. The PHPUnit 10 compat for the deprecations handler will have to leverage those events, but as of now having two error handlers is just causing errors, and it does not make sense spending work to make them compatible. Hence, this patch.