Skip to content

Backport option to enable Sandbox via dsn option sandbox=true to 5.4 #49453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

mdawart
Copy link
Contributor

@mdawart mdawart commented Feb 20, 2023

Q A
Branch? 5.4
Bug fix? sync with 6.3 PR #49429
New feature? yes/no
Deprecations? no
Tickets Fix #49410
License MIT
Doc PR <!--

Created this to have this option in 5.4 as some projects are not yet updated

Mailjet introduced a Sandbox Mode https://dev.mailjet.com/email/guides/send-api-v31/#sandbox-mode that allows to use the API but not sending any email e.g. for debugging.

MAILER_DSN=mailjet+api://$PUBLIC_KEY:$PRIVATE_KEY@default?sandbox=true

@stof
Copy link
Member

stof commented Feb 20, 2023

This looks like a new feature, not a bugfix. So to me, this should go in 6.3, not in 5.4

@mdawart
Copy link
Contributor Author

mdawart commented Feb 20, 2023

Yes I already prepared a PR for 6.3 that already got reviewed here: #49429 but I am wondering if there is any chance to have it in 5.4 as most of the projects I am working on are not yet updated and I want to avoid to use a symfony fork

@stof
Copy link
Member

stof commented Feb 20, 2023

symfony/mailjet-mailer 6.3.x-dev is compatible with symfony/mailer 5.4, so it should be possible to upgrade only that package (it will probably require using normal composer.json constraints instead of relying on Flex's symfony_require feature forcing a specific Symfony version for all packages though)

@mdawart mdawart closed this Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants