Skip to content

[Notifier] Add Pushover bridge #49454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2023
Merged

[Notifier] Add Pushover bridge #49454

merged 1 commit into from
Feb 23, 2023

Conversation

mocodo
Copy link
Contributor

@mocodo mocodo commented Feb 20, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#17928
Recipe symfony/recipes#1178

This PR add the Pushover Notifier bridge

@mocodo mocodo requested a review from OskarStark as a code owner February 20, 2023 12:44
@carsonbot carsonbot added this to the 6.3 milestone Feb 20, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@mocodo mocodo force-pushed the notifier-pushover-provider branch 3 times, most recently from a526fcd to 34ded20 Compare February 20, 2023 13:15
@mocodo
Copy link
Contributor Author

mocodo commented Feb 20, 2023

Not sure that the CI failing has a link to the added/modified code.

I'd be happy to correct anything wrong.

nicolas-grekas
nicolas-grekas reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, here are some minor comments.

@mocodo mocodo force-pushed the notifier-pushover-provider branch 3 times, most recently from 19f8f37 to d2a8e9f Compare February 23, 2023 13:14
@nicolas-grekas nicolas-grekas force-pushed the notifier-pushover-provider branch from d2a8e9f to 0f07fd5 Compare February 23, 2023 14:45
@nicolas-grekas
Copy link
Member

Thank you @mocodo.

@nicolas-grekas nicolas-grekas merged commit 23ea82d into symfony:6.3 Feb 23, 2023
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Feature Notifier Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mocodo @carsonbot @nicolas-grekas