Skip to content

[Form] Skip password hashing on empty password #49459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2023
Merged

[Form] Skip password hashing on empty password #49459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Component/Form/Extension/PasswordHasher/EventListener/PasswordHasherListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ public function __construct(

public function registerPassword(FormEvent $event)
{
if (null === $event->getData() || '' === $event->getData()) {
return;
}

$this->assertNotMapped($event->getForm());

$this->passwords[] = [
Expand Down
31 changes: 31 additions & 0 deletions ...nent/Form/Tests/Extension/PasswordHasher/Type/PasswordTypePasswordHasherExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

use PHPUnit\Framework\MockObject\MockObject;
use Symfony\Component\Form\Exception\InvalidConfigurationException;
use Symfony\Component\Form\Extension\Core\Type\FormType;
use Symfony\Component\Form\Extension\Core\Type\PasswordType;
use Symfony\Component\Form\Extension\Core\Type\RepeatedType;
use Symfony\Component\Form\Extension\PasswordHasher\EventListener\PasswordHasherListener;
Expand Down Expand Up @@ -80,6 +81,36 @@ public function testPasswordHashSuccess()
$this->assertSame($user->getPassword(), $hashedPassword);
}

public function testPasswordHashSkippedWithEmptyPassword()
{
$oldHashedPassword = 'PreviousHashedPassword';

$user = new User();
$user->setPassword($oldHashedPassword);

$this->passwordHasher
->expects($this->never())
->method('hashPassword')
;

$this->assertEquals($user->getPassword(), $oldHashedPassword);

$form = $this->factory
->createBuilder(FormType::class, $user)
->add('plainPassword', PasswordType::class, [
'hash_property_path' => 'password',
'mapped' => false,
'required' => false,
])
->getForm()
;

$form->submit(['plainPassword' => '']);

$this->assertTrue($form->isValid());
$this->assertSame($user->getPassword(), $oldHashedPassword);
}

public function testPasswordHashSuccessWithEmptyData()
{
$user = new User();
Expand Down