[Mailer] Add new attributes to Infobip API transport #49491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cf1959 to
2ade00d
Compare
OskarStark
reviewed
Feb 25, 2023
| 6.3 | ||
| --- | ||
|
|
||
| * Add infobip reporting behavior thanks to new attributes support |
There was a problem hiding this comment.
Suggested change
| * Add infobip reporting behavior thanks to new attributes support | |
| * Add reporting behavior thanks to new attributes support |
2ade00d to
5a20137
Compare
B-Galati
reviewed
Mar 1, 2023
| @@ -123,6 +123,24 @@ private function formDataPart(Email $email, Envelope $envelope): FormDataPart | |||
|
|
|||
| $this->attachmentsFormData($fields, $email); | |||
|
|
|||
| $headers = $email->getHeaders(); | |||
|
|
|||
| if ($headers->has('intermediateReport')) { | |||
There was a problem hiding this comment.
I think that all custom headers specific to a provider should be prefixed with something like X-Infobip-.
It will prevent collision with other providers that may use the same custom headers.
You can look at other provider code 👍
There was a problem hiding this comment.
Thanks for this feedback. I reworked the code to use the same behavior as Mailjet and I think it's better.
I tried it too in real condition in our projet and it works as expected.
bb9164d to
469a10c
Compare
B-Galati
approved these changes
Mar 2, 2023
03cab3d to
4d7facd
Compare
OskarStark
approved these changes
Apr 4, 2023
fabpot
approved these changes
Apr 5, 2023
|
Thank you @ndousson. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 Context
Infobip has a mechanism to send back SMS status like webhook do.
To do that, we need to add some attributes to the payload.
This MR aim to add this attributes.
It's a need for our company so I hope this new "feature" will be supported by the transport.
➕ New feature
New payload attributes was added allowing end users to use the reporting.
application/jsonorapplication/xml.ℹ️ Note that no one of this attributes are required.