[Form] Change FormTypeValidatorExtension construct signature #49502
+123
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
Feb 22, 2023
src/Symfony/Component/Form/Extension/Validator/Type/FormTypeValidatorExtension.php
Outdated
Show resolved
Hide resolved
alamirault
commented
Feb 22, 2023
c74bc36 to
43f04bb
Compare
HypeMC
reviewed
Feb 22, 2023
src/Symfony/Component/Form/Extension/Validator/Type/FormTypeValidatorExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Validator/Type/FormTypeValidatorExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Validator/Type/FormTypeValidatorExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Validator/Type/FormTypeValidatorExtension.php
Outdated
Show resolved
Hide resolved
2c616dd to
a9e9b85
Compare
xabbuh
reviewed
Mar 1, 2023
xabbuh
reviewed
Mar 1, 2023
xabbuh
reviewed
Mar 1, 2023
src/Symfony/Component/Form/Extension/Validator/Type/FormTypeValidatorExtension.php
Show resolved
Hide resolved
Co-authored-by: Christian Flothmann <christian.flothmann@gmail.com>
stof
reviewed
Apr 20, 2023
| /** | ||
| * @group legacy | ||
| */ | ||
| public function testLegacyWithBadFormRendererType() |
There was a problem hiding this comment.
This is not the legacy signature, but the new one though, as you don't pass the boolean.
There was a problem hiding this comment.
You are right. But when type hint will be set in 7.0. Args checking will be drop and tests must also be dropped.
I can keep @group legacy and only remove legacy in function name ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$legacyErrorMessagesis required inFormTypeValidatorExtensionconstruct but it is not used anymore in class. This PR deprecate passing this argument.