Skip to content

[Security] Remove @internal tag on TraceableAuthenticator::getAuthenticator() #49541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

florentdestremau
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets See #49015
License MIT

Following the discussion in #49015 I made this PR

@carsonbot carsonbot added this to the 5.4 milestone Feb 27, 2023
@florentdestremau florentdestremau changed the title Fix/remove internal on getauthenticator [Security] Remove @internal tag on TraceableAuthenticator::getauthenticator Feb 27, 2023
@florentdestremau florentdestremau force-pushed the fix/remove-internal-on-getauthenticator branch from 9813670 to 0a8ba93 Compare February 27, 2023 09:34
@OskarStark OskarStark changed the title [Security] Remove @internal tag on TraceableAuthenticator::getauthenticator [Security] Remove @internal tag on TraceableAuthenticator::getAuthenticator() Feb 27, 2023
@carsonbot carsonbot changed the title [Security] Remove @internal tag on TraceableAuthenticator::getAuthenticator() Remove @internal tag on TraceableAuthenticator::getAuthenticator() Feb 27, 2023
@carsonbot carsonbot changed the title Remove @internal tag on TraceableAuthenticator::getAuthenticator() [Security] Remove @internal tag on TraceableAuthenticator::getAuthenticator() Mar 2, 2023
@nicolas-grekas
Copy link
Member

Thank you @florentdestremau.

@nicolas-grekas nicolas-grekas merged commit e8b2fb7 into symfony:5.4 Mar 2, 2023
@florentdestremau florentdestremau deleted the fix/remove-internal-on-getauthenticator branch March 2, 2023 09:02
This was referenced Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants