Skip to content

[OptionsResolver] add ignoreUndefined() method to allow skip not interesting options #49608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

[OptionsResolver] add ignoreUndefined() method to allow skip not interesting options #49608

merged 1 commit into from
May 5, 2023

Conversation

kshtompel
Copy link

@kshtompel kshtompel commented Mar 6, 2023 •
edited by GromNaN
Loading

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #45370
License MIT
Doc PR NOT ADDED

Allow to ignore not defined options to allow skip not interesting options when working with big set of shared configuration or just not to describe all the options provided by third party provider

@kshtompel kshtompel requested a review from yceruto as a code owner March 6, 2023 01:17
@carsonbot carsonbot added this to the 6.3 milestone Mar 6, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

nicolas-grekas
nicolas-grekas reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, here are some minor comments.

@carsonbot carsonbot changed the title - add ignoreUndefined() method to allow skip not interesting options [OptionsResolver] - add ignoreUndefined() method to allow skip not interesting options Mar 9, 2023
@nicolas-grekas nicolas-grekas changed the title [OptionsResolver] - add ignoreUndefined() method to allow skip not interesting options [OptionsResolver] add ignoreUndefined() method to allow skip not interesting options Mar 9, 2023
@nicolas-grekas
Copy link
Member

Please add a changelog entry indeed.

@OskarStark
Copy link
Contributor

It looks like your committer email is not associated with your Github account.

@kshtompel
Copy link
Author

Do I need recreate PR with new email configured or can leave it as is and commit changes with update email associated with the account

@kshtompel
Copy link
Author

@nicolas-grekas
Please advise where to put CHANGELOG update.
PR is made for version 6.3
but I see only 6.2 CHANGELOG file latest

@kshtompel
Copy link
Author

please advise how to change changelog file for the new feature

@yceruto
Copy link
Member

yceruto commented Mar 23, 2023

@kshtompel you can update the changelog in this file src/Symfony/Component/OptionsResolver/CHANGELOG.md

yceruto
yceruto requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's almost ready for me. I've left you some minor changes.

@kshtompel
Copy link
Author

Added CHANGELOG note for version 6.2

@GromNaN GromNaN requested a review from yceruto March 24, 2023 19:06
@OskarStark OskarStark changed the title [OptionsResolver] add ignoreUndefined() method to allow skip not interesting options [OptionsResolver] add ignoreUndefined() method to allow skip not interesting options Mar 26, 2023
@kshtompel
Copy link
Author

any updates so far?

@kshtompel
Copy link
Author

@nicolas-grekas
@yceruto
do i need change something?

@kshtompel
Copy link
Author

@yceruto something else here?

yceruto
yceruto requested changes Apr 28, 2023
View reviewed changes
Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One move left and LGTM. Thank you!

@nicolas-grekas nicolas-grekas force-pushed the feature/45370-option-resolver-improve branch from c485514 to 21cd852 Compare May 2, 2023 16:27
@fabpot
Copy link
Member

fabpot commented May 5, 2023

Thank you @kshtompel.

@fabpot fabpot mentioned this pull request May 5, 2023
Closed
@fabpot fabpot merged commit aafb106 into symfony:6.3 May 5, 2023
@fabpot fabpot mentioned this pull request May 7, 2023
Merged
@yceruto yceruto mentioned this pull request May 12, 2023
Merged
nicolas-grekas added a commit that referenced this pull request May 12, 2023
@nicolas-grekas
bug #50305 [OptionsResolver] Fixed changelog (yceruto)
0513ce8 
This PR was merged into the 6.3 branch.

Discussion
----------

[OptionsResolver] Fixed changelog

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

#49608

Commits
-------

61279d4 Fixed changelog
@kshtompel
Copy link
Author

kshtompel commented May 16, 2023 •
edited
Loading

@yceruto
I didn't change method definition in the CHANGELOG.md to OptionsResolver::setIgnoreUndefined()
it is still has OptionsResolver::ignoreUndefined()

6.3

  • Add OptionsResolver::ignoreUndefined() to ignore not defined options while resolving

Do I need create another PR to make this changes??

@yceruto
Copy link
Member

yceruto commented May 16, 2023

Don't worry, I already updated it here #50305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@GromNaN GromNaN GromNaN approved these changes

@OskarStark OskarStark OskarStark left review comments

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Feature OptionsResolver Ready Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

Allow extra options in OptionsResolver
7 participants
@kshtompel @carsonbot @nicolas-grekas @OskarStark @yceruto @fabpot @GromNaN