[Translation] Wrap call to \Locale::setDefault from LocaleSwitcher in a class_exists call #49609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about wrapping the call to |
You mean Let's do that instead. |
|
No worries, will update |
derrabus
requested changes
Mar 7, 2023
nicolas-grekas
approved these changes
Mar 7, 2023
|
Thank you @larowlan. |
|
Oh right I missed it was assigning too 🙂 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #45793 a new LocaleSwitcher was added which uses the \Locale class from ext-intl.
On upgrading an English only project from 5.4 to 6.2, I received the following error as we don't have the ext-intl extension
I searched for previous PRs to add a dependency on
ext-intland came across one for the string component directing the user to install a polyfill.Should symfony/translation therefore depend on the polyfill - otherwise updating is broken without manually installing the polyfill?
If so, here's a PR for that.
Keep up the good work folks ❤️