Skip to content

[Form] Improve exception for unsubmitted form #49667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

KThiebault
Copy link
Contributor

@KThiebault KThiebault commented Mar 10, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #49619
License MIT
Doc PR -

This PR improves the error message when a form is submitted but its submission is not verified.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@yceruto
Copy link
Member

yceruto commented Mar 11, 2023

I think the new error message is better! Thanks for contributing to the project.

@KThiebault KThiebault requested review from yceruto and removed request for xabbuh March 11, 2023 11:50
@fabpot fabpot force-pushed the feature/form-improve-exception branch from 59af0df to 51d3038 Compare March 13, 2023 19:13
@fabpot
Copy link
Member

fabpot commented Mar 13, 2023

Thank you @KThiebault.

@fabpot fabpot merged commit 6b14137 into symfony:6.3 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error exception for unsubmitted form
5 participants