[DependencyInjection] Generalize and simplify parsing of autowiring attributes #49683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd64a47 to
f53341e
Compare
f53341e to
e154659
Compare
stof
approved these changes
Mar 14, 2023
|
Thanks for the quick review @stof |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the relationship between the
Autowireand theTypedReferenceclasses, allowing to nest them inside each others (as supported already), but without loosing information in the process.It also removes the
AutowiringFailedExceptioncurrently thrown when encountering unknown attributes, to respect the declarative nature of attributes.