Skip to content

[Serializer] Add missing withSaveOptions method to XmlEncoderContextBuilder #49760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2023
Merged

[Serializer] Add missing withSaveOptions method to XmlEncoderContextBuilder #49760

merged 1 commit into from
May 4, 2023

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Mar 21, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Add missing withSaveOptions method to XmlEncoderContextBuilder to handle XmlEncoder::SAVE_OPTIONS context value.

@mtarld mtarld requested a review from dunglas as a code owner March 21, 2023 17:32
@carsonbot carsonbot added this to the 6.3 milestone Mar 21, 2023
chalasr
chalasr approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 6.3 fine-tuning

@chalasr
Copy link
Member

chalasr commented May 4, 2023

Thank you @mtarld.

@chalasr chalasr merged commit ae771ad into symfony:6.3 May 4, 2023
@mtarld mtarld deleted the fix/add-xml-save-option-context-builder branch May 4, 2023 03:37
@fabpot fabpot mentioned this pull request May 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mtarld @chalasr @dunglas @carsonbot