Skip to content

[Cache] Fix php7 compat on 5.4: null coalescing assignment operator #49862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023
Merged

[Cache] Fix php7 compat on 5.4: null coalescing assignment operator #49862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Cache/Adapter/DoctrineDbalAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ protected function doSave(array $values, int $lifetime)
*/
protected function getId($key)
{
if ('pgsql' !== $this->platformName ??= $this->getPlatformName()) {
if ('pgsql' !== $this->getPlatformName()) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$this->getPlatformName() already memoizes its return value on $this->platformName, so I don't see a reason to shortcut that anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance, getId() is on the hotpath. But fine for 5.4, and the roundtrip to the DB is likely going the slow part anyway.

return parent::getId($key);
}

Expand Down