[VarDumper] Reduce stylesheet assignments via JavaScript in HtmlDumper
#49977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
c1aa788 to
beb090e
Compare
nicolas-grekas
approved these changes
May 14, 2023
beb090e to
53046a3
Compare
|
Thank you @ohader. |
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Jun 26, 2023
The admin panel uses Symfony's `HtmlDumper` to output data - which is adding inline JavaScript and StyleSheet elements. To be compatible with CSP those elements need to be allowed with a nonce attribute. This change relies on a merged pull request for Symfony v6.3: symfony/symfony#49977 Executed commands: composer req symfony/var-dumper:^6.3 composer req symfony/var-dumper:^6.3 \ -d typo3/sysext/adminpanel --no-update Resolves: #100456 Releases: main, 12.4 Change-Id: I7fcea196107959db85257c7d735f85a9e78839d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78512 Reviewed-by: Georg Ringer <georg.ringer@gmail.com> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Benni Mack <benni@typo3.org> Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by: core-ci <typo3@b13.com>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/adminpanel
that referenced
this pull request
Jun 26, 2023
The admin panel uses Symfony's `HtmlDumper` to output data - which is adding inline JavaScript and StyleSheet elements. To be compatible with CSP those elements need to be allowed with a nonce attribute. This change relies on a merged pull request for Symfony v6.3: symfony/symfony#49977 Executed commands: composer req symfony/var-dumper:^6.3 composer req symfony/var-dumper:^6.3 \ -d typo3/sysext/adminpanel --no-update Resolves: #100456 Releases: main, 12.4 Change-Id: I7fcea196107959db85257c7d735f85a9e78839d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78512 Reviewed-by: Georg Ringer <georg.ringer@gmail.com> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Benni Mack <benni@typo3.org> Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by: core-ci <typo3@b13.com>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/frontend
that referenced
this pull request
Jun 26, 2023
The admin panel uses Symfony's `HtmlDumper` to output data - which is adding inline JavaScript and StyleSheet elements. To be compatible with CSP those elements need to be allowed with a nonce attribute. This change relies on a merged pull request for Symfony v6.3: symfony/symfony#49977 Executed commands: composer req symfony/var-dumper:^6.3 composer req symfony/var-dumper:^6.3 \ -d typo3/sysext/adminpanel --no-update Resolves: #100456 Releases: main, 12.4 Change-Id: I7fcea196107959db85257c7d735f85a9e78839d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78512 Reviewed-by: Georg Ringer <georg.ringer@gmail.com> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Benni Mack <benni@typo3.org> Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by: core-ci <typo3@b13.com>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Jun 26, 2023
The admin panel uses Symfony's `HtmlDumper` to output data - which is adding inline JavaScript and StyleSheet elements. To be compatible with CSP those elements need to be allowed with a nonce attribute. This change relies on a merged pull request for Symfony v6.3: symfony/symfony#49977 Executed commands: composer req symfony/var-dumper:^6.3 composer req symfony/var-dumper:^6.3 \ -d typo3/sysext/adminpanel --no-update Resolves: #100456 Releases: main, 12.4 Change-Id: I7fcea196107959db85257c7d735f85a9e78839d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79204 Tested-by: core-ci <typo3@b13.com> Tested-by: Oliver Hader <oliver.hader@typo3.org> Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/adminpanel
that referenced
this pull request
Jun 26, 2023
The admin panel uses Symfony's `HtmlDumper` to output data - which is adding inline JavaScript and StyleSheet elements. To be compatible with CSP those elements need to be allowed with a nonce attribute. This change relies on a merged pull request for Symfony v6.3: symfony/symfony#49977 Executed commands: composer req symfony/var-dumper:^6.3 composer req symfony/var-dumper:^6.3 \ -d typo3/sysext/adminpanel --no-update Resolves: #100456 Releases: main, 12.4 Change-Id: I7fcea196107959db85257c7d735f85a9e78839d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79204 Tested-by: core-ci <typo3@b13.com> Tested-by: Oliver Hader <oliver.hader@typo3.org> Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/frontend
that referenced
this pull request
Jun 26, 2023
The admin panel uses Symfony's `HtmlDumper` to output data - which is adding inline JavaScript and StyleSheet elements. To be compatible with CSP those elements need to be allowed with a nonce attribute. This change relies on a merged pull request for Symfony v6.3: symfony/symfony#49977 Executed commands: composer req symfony/var-dumper:^6.3 composer req symfony/var-dumper:^6.3 \ -d typo3/sysext/adminpanel --no-update Resolves: #100456 Releases: main, 12.4 Change-Id: I7fcea196107959db85257c7d735f85a9e78839d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79204 Tested-by: core-ci <typo3@b13.com> Tested-by: Oliver Hader <oliver.hader@typo3.org> Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic
<style>element in the JavaScript variablerefStylecan be replaced by static CSS and element states.The new rule
.sf-dump-hover:hoversubstitutes JavaScript event handling formouseoverevents.This is a preparation to have the possibility to assign
nonceHTML attributes to inline<script>and<style>nodes, e.g. shown as proof-of-concept athttps://review.typo3.org/c/Packages/TYPO3.CMS/+/78512/2/typo3/sysext/adminpanel/Classes/Utility/HtmlDumper.php