[Serializer] Fix serializer normalize attribute context #50015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f6869d to
942a184
Compare
|
Thank you @akalineskou. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 6.2.8 property attribute
#[Context(normalizationContext: [AbstractObjectNormalizer::SKIP_NULL_VALUES => true])]was working correctlyBefore this PR #49525
updateDatawas using the$attributeContextbut it got changed to using$context(which ignored the attribute context)Fixed the
testNormalizeUsesContextAttributeForPropertiesInConstructorWithSerializedPathtest also sinceContextattribute class was never used in the file (the date was still ind-m-Yformat when the format key wasm-d-Y)Would have ported it to 5.4, but it was not added in that branch.
Latest commit for this file in 5.4
symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Line 205 in 6ae4ac9