-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] Fix support of Enum to ConstraintValidator::formatValue
#50017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.2". Cheers! Carsonbot |
Sorry, first time making a PR. I think it's changed now. |
I'm wondering whether this should be done only when the |
ConstraintValidator::formatValue
I have changed so enums are treated more like objects, if there isn't an OBJECT_TO_STRING flag they are displayed as "enum"; if the flag is present it returns the enum name. I have also added both test cases (with or without the flag). |
Tests passed but failed because of unrelated |
ConstraintValidator::formatValue
ConstraintValidator::formatValue
ae9ca65
to
128b3da
Compare
Thank you @PhoneixS. |
You’re welcome. It's always nice to return a little bit to a great project. |
I have added a simple check in the
formatValue
to see if the object is an enum and in that case, return the name of the enum instead of the "object" string.