• Update CHANGELOG.md
• Update whatever is needed for BC breaks
• Ensure serialization works across a full failing message (failed decoding into encoding)

Problem

Handling deserialization in transports prevents actual error handling from running... And depending on transports, can even drop messages. While envelope and stamps deserialization failures may be actual error warranting undefined behavior, message denormalization failures is merely an application concern. Symfony should never drop messages that are broken by the application.

Solution

Reusing some part of #39622:

• Ensure both PhpSerializer and Serializer do not throw error in message deserialization
  • Stamps and envelope are still allowed to throw.
  • Remove toggling incomplete classes from PhpSerializer
• Handle MessageDecodingFailedStamp in Worker
  • Trigger standard message rejection (event and retry into full rejection)
• Ensure compatibility with AbstractFailedMessagesCommand

BC breaks

• Messenger\Transport\Serialization\Serializer::__construct() first arguments goes from ?SerializerInterface $serializer = null to DecoderInterface&DenormalizerInterface&SerializerInterface $serializer
  • To support distinguishing between encoding errors and normalization errors, we must call each separately. This requires an intersection of interfaces
  • Framework always pass a constructed serializer, so no issue
  • No other instantiations are done... So only BC breaks will be in standalone uses passing null as first argument
  • Messenger\Transport\Serialization\Serializer::create() still return a default constructed instance