[Intl] Allow compressing emoji and data maps #50055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
593cf3d to
8d58244
Compare
|
My review at #49970 (review) applies to this PR then. |
8d58244 to
d7c4da8
Compare
nicolas-grekas
commented
Apr 18, 2023
| @@ -178,7 +178,7 @@ public static function buildStripRules(array $emojisCodePoints): iterable | |||
| $maps[$codePointsCount][$emoji] = ''; | |||
| } | |||
|
|
|||
| return ['strip' => self::createRules($maps)]; | |||
| return ['emoji-strip' => self::createRules($maps)]; | |||
There was a problem hiding this comment.
those changes are not directly related, although I found them while running the script
d7c4da8 to
913bd59
Compare
dkarlovi
approved these changes
Apr 18, 2023
|
CI updated to run the intl tests with compressed data. |
stof
reviewed
Apr 18, 2023
913bd59 to
de6a74c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resuming #49970, which was closed by mistake :)