Skip to content

Fix the semaphore tests #50091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

Fix the semaphore tests #50091

merged 1 commit into from
Apr 21, 2023

Conversation

stof
Copy link
Member

@stof stof commented Apr 21, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

The save method of the store is not meant to return a boolean. And with the new void type in the phpdoc, phpunit complains about that.

@carsonbot carsonbot added this to the 6.3 milestone Apr 21, 2023
@stof
Fix the semaphore tests
93d0caa 
The save method of the store is not meant to return a boolean.
@stof stof force-pushed the fix_semaphore_tests branch from 29e085d to 93d0caa Compare April 21, 2023 11:46
@fabpot
Copy link
Member

fabpot commented Apr 21, 2023

Thank you @stof.

@fabpot fabpot merged commit 5166629 into symfony:6.3 Apr 21, 2023
@stof stof deleted the fix_semaphore_tests branch April 21, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@stof @fabpot @nicolas-grekas @carsonbot