[Cache] Prevent unnecessary file IO #50095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is correct. These are guard checks to me, the order matters. |
|
Well, switching the IO check and the boolean check is fine to me. However, the ones linked in the description indeed can be changed as we cannot change the order for write IO operation (skipping a IO write is not an optimization opportunity) |
|
BUT, the check looks wrong to me! it should be "unlink || !file_exists"! |
fabpot
added a commit
that referenced
this pull request
Apr 21, 2023
…abm) This PR was merged into the 5.4 branch. Discussion ---------- [Cache] Fix success interpretation when pruning cache | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the latest branch. - For new features, provide some code snippets to help understand usage. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> As discussed in #50095 this PR fixes the interpretation when cache-pruning is considered successfull. This is changed to use the same semantics used in other places of the codebase, e.g. https://github.com/symfony/symfony/blob/51666290232ee13165c98fa9e40d3475a3cabfd8/src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php#L62 https://github.com/symfony/symfony/blob/51666290232ee13165c98fa9e40d3475a3cabfd8/src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php#L74 Commits ------- 76a2e62 [Cache] Fix success interpretation when pruning cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #50087 this prevents file IO by re-ordering conditions.
There were even more similar code spots, but I wondered because they have different semantics
(different interpretation of success because of the placement of parantheses)
symfony/src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php
Line 62 in 5166629
symfony/src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php
Line 74 in 5166629