Profiler respect stateless attribute #50218
Conversation
|
#50198 was a new feature so it is only available on the 6.3 branch 😅 I looked for a way to test this and it seems we have to update |
src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
Outdated
Show resolved
Hide resolved
a763930 to
7820776
Compare
|
Thank you @alamirault. |
| $session = $request->hasSession() ? $request->getSession() : null; | ||
|
|
||
| $session = null; | ||
| if ($request->attributes->getBoolean('_stateless') && $request->hasSession()) { |
There was a problem hiding this comment.
I know I am late, but I thought posting it here was less interruptive then creating a new issue or discussion for this question:
The PR touches 3 placed where it gets the session and adds checks for the _stateless request attribute.
Two checks check for !stateless && hasSession while one of them (in searchBarAction) checks for stateless && hasSession (without the !).
I found this while debugging for what starts Session was used while the request was declared stateless. when calling the profiler. As far as I can tell, the only place using the session there is the this spot.
This line looks incorret to me, I think its missing the ! in front. But since I'm probably wrong (since this is like this for a year now, with no one noticing) I'd like to learn why I am wrong!
There was a problem hiding this comment.
Just tested and you’re not wrong. Maybe you really are the first to notice 😅
There was a problem hiding this comment.
If I understand the implications of this correct, then that means that for users that have stateless: false, restoring the search bar state from session should not work, as it would not use the session in those cases. It would only use the session if stateless: true (e.g. when there should be no session). Correct?
There was a problem hiding this comment.
for users that have
stateless: false, restoring the search bar state from session should not work
Yes, that also includes users who did not set _stateless. Are you up for a PR? Looks like you already know the fix!
There was a problem hiding this comment.
I can give it a try: #57679
Hope thats correct so far.
Now that #50198 forward
_statelessattribute in fragments, this PR check this attribute and make profiler stateless when is required.I don't know which tests I have to add because session is not checked. (I checked on reproducer and it's ok)