[Mime] Add PGP feature #50222
[Mime] Add PGP feature #50222
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| @@ -17,6 +17,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=8.1", | |||
| "pear/crypt_gpg": "^1.6", | |||
There was a problem hiding this comment.
This needs to be moved to require-dev as said in previous comment.
There was a problem hiding this comment.
Haven't I moved it to require-dev in d5b9214?
I'm glad you like the idea of that feature. A new component would be essential a standalone package under a certain namespace?
There was a problem hiding this comment.
Haven't I moved it to require-dev in d5b9214?
The commit sorts packages alphabetically, but does not move the package to require-dev.
There was a problem hiding this comment.
Yeah, I did that too. But it is actually under require-dev now:
There was a problem hiding this comment.
d5b9214 fixes the composer.json in the root dir, this is src/Symfony/Component/Mime/composer.json.
There was a problem hiding this comment.
I see. If it should't live in symfony/mime then it should be entirely removed from there and instead moved into a new component (for example symfony/pgp) where the dependency is handled?
There was a problem hiding this comment.
Hey,
the last months I tested my implementation in a Symfony app and discovered several flaws. For example it doesn't work with templated emails and sending via mail provider via api is also not possible due to the nature of a PGP structured mail.
I still would like to see that feature in Symfony and I'll work on that in the upcoming weeks.
|
@the-pulli Are you still willing to work on this? I agree with the previous comment that it should be part of a new component that would be well integrated with Mime. |
|
Sure @fabpot , I can give it another shot. My mentioned package from #50160 still working well for me in a Laravel app. But I discovered that most of the transactional mail provider doesn't support PGP encryption. The ones working for me were Mailtrap.io and ZohoMail. I keep you posted with updates and it's nice to know that there's still a demand for this feature. |
|
Is it really necessary to use
I am also interested in this feature. I can make myself available to help integrate it |
|
Closing in favor of #59372 |
As discussed in #50160 here is the corresponding PR.