Skip to content

[FrameworkBundle][Webhook] Throw when required services are missing when using the Webhook component #50230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

[FrameworkBundle][Webhook] Throw when required services are missing when using the Webhook component #50230

merged 1 commit into from
May 9, 2023

Conversation

Jean-Beru
Copy link
Contributor

@Jean-Beru Jean-Beru commented May 3, 2023 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50211
License MIT
Doc PR

@carsonbot carsonbot added this to the 6.3 milestone May 3, 2023
@nicolas-grekas
Copy link
Member

In #50260, I improved a bit the way to register errored definition. Can you please have a look?

@Jean-Beru Jean-Beru force-pushed the fix/50211-webhook-deps branch from 9d7171f to 84b7358 Compare May 9, 2023 14:25
@Jean-Beru
Copy link
Contributor Author

Thanks for the review and the tip about #50260 ! I've added a check on serializer.enabled.

@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle][Webhook] Services are missing when requiring Webhook component [FrameworkBundle][Webhook] Throw when required services are missing when using the Webhook component May 9, 2023
@nicolas-grekas nicolas-grekas force-pushed the fix/50211-webhook-deps branch from c33ba39 to fd3185e Compare May 9, 2023 15:15
nicolas-grekas
nicolas-grekas approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the implementation a bit.

@nicolas-grekas
Copy link
Member

Thank you @Jean-Beru.

@nicolas-grekas nicolas-grekas merged commit a0b1ddb into symfony:6.3 May 9, 2023
@Jean-Beru Jean-Beru deleted the fix/50211-webhook-deps branch May 9, 2023 15:51
@fabpot fabpot mentioned this pull request May 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed Webhook
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

[FrameworkBundle][Webhook] Services are missing when requiring Webhook component
3 participants
@Jean-Beru @nicolas-grekas @carsonbot