[AssetMapper] Better public without digest #50232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
May 3, 2023
| } | ||
|
|
||
| return $this->extensionsMap[$extension]; | ||
| return $this->extensionsMap[$extension] ?? null; |
There was a problem hiding this comment.
This is unrelated. I had a file that mentioned a sourcemap - so foo.js.map - and the system exploded because we didn't know the mime type of .map. The mime type is only important for (A) the dev server to return that asset with the correctContent-Type and (B) for asset compilers, if they rely on the mime type. So I think this is a reasonable thing to do.
11641cb to
4dbdca0
Compare
stof
approved these changes
May 5, 2023
nicolas-grekas
approved these changes
May 5, 2023
4dbdca0 to
54ebd6d
Compare
|
Thank you @weaverryan. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a
MappedAsset::getPublicPathWithoutDigest()method, which would return something like/assets/file2.js. This, sort of odd method, is super useful, for example, when generating the importmap, where we want to communicate to the browser that when it searches for/assets/file2.js(e.g. because insideassets/file1.jsthere is animport './file1.js'), here it should use the digested path - e.g.Anyway, the way that I calculated this originally was a little sketchy. In truth, we have this info very easily in
AssetMapper, so now we pass it in. This also allows an "asset compiler" to figure out which "directory" the final asset will be in, which isn't possible with "public path" as it's still being generated. That little nice detail will be needed in StimulusBundle :).Cheers!