[ErrorHandler] Fix the design of the exception page tabs #50242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
May 5, 2023
fabpot
approved these changes
May 5, 2023
|
Thank you @javiereguiluz. |
Merged
fabpot
added a commit
that referenced
this pull request
May 12, 2023
…atTheCat) This PR was merged into the 6.3 branch. Discussion ---------- [ErrorHandler] Sync `createTabs` from WebProfilerBundle | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A WebProfilerBundle’s `base_js.html.twig` and ErrorHandler’s `exception.js` are out of sync: the latter won’t affect the `tab-control` class. This break the exception page tabs’ style after it was updated by #50242 Before:  After:  Commits ------- 18df31b Sync `createTabs` from WebProfilerBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfony 6.3 we've updated the tabs of the Profiler to make them accessible. In turn, this also updates the tabs of the exception page from ErrorHandler. However, the design of that exception page hasn't been updated yet, so it looks like this:
Now the tabs look like the profiler. It's not perfect, but it's better than the current broken situation. The proper fix is to update a bit the design of the exception page. Let's do that for Symfony 6.4/7.0. Thanks!