Skip to content

[Serializer] Handle datetime deserialization in U format #50251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2023
Merged

[Serializer] Handle datetime deserialization in U format #50251

merged 1 commit into from
May 12, 2023

Conversation

tugmaks
Copy link
Contributor

@tugmaks tugmaks commented May 6, 2023 •
edited by nicolas-grekas
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50236
License MIT
Doc PR -

Fixes #50236

@tugmaks tugmaks requested a review from dunglas as a code owner May 6, 2023 18:23
@carsonbot carsonbot added this to the 6.2 milestone May 6, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@tugmaks tugmaks changed the title Handle datetime deserialization in U format [Serializer] Handle datetime deserialization in U format May 6, 2023
@OskarStark OskarStark requested a review from stof May 7, 2023 09:54
@tugmaks tugmaks force-pushed the datetime-denormalize-u-format branch from 1bd2cd2 to 3e87d75 Compare May 10, 2023 14:56
@carsonbot carsonbot changed the title [Serializer] Handle datetime deserialization in U format Handle datetime deserialization in U format May 12, 2023
@carsonbot carsonbot changed the title Handle datetime deserialization in U format [Serializer] Handle datetime deserialization in U format May 12, 2023
@nicolas-grekas nicolas-grekas force-pushed the datetime-denormalize-u-format branch from 803bcf8 to 8149ee9 Compare May 12, 2023 08:29
@nicolas-grekas nicolas-grekas changed the base branch from 6.2 to 5.4 May 12, 2023 08:35
@nicolas-grekas nicolas-grekas force-pushed the datetime-denormalize-u-format branch from 8149ee9 to 11d05ad Compare May 12, 2023 08:35
@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 5.4 May 12, 2023
@nicolas-grekas nicolas-grekas force-pushed the datetime-denormalize-u-format branch from 11d05ad to a5d1ca6 Compare May 12, 2023 08:37
@nicolas-grekas
Copy link
Member

Thank you @tugmaks.

@nicolas-grekas nicolas-grekas merged commit 2caaddc into symfony:5.4 May 12, 2023
@tugmaks
Copy link
Contributor Author

tugmaks commented May 12, 2023

Thank you @tugmaks.

Thank you too!

@nicolas-grekas nicolas-grekas mentioned this pull request May 12, 2023
Closed
@fabpot fabpot mentioned this pull request May 13, 2023
Merged
@Hanmac Hanmac mentioned this pull request May 24, 2023
Merged
This was referenced May 27, 2023
Merged
Merged
@tugmaks tugmaks deleted the datetime-denormalize-u-format branch September 27, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@stof stof Awaiting requested review from stof

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@OskarStark OskarStark Awaiting requested review from OskarStark

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Serializer Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@tugmaks @carsonbot @nicolas-grekas