Skip to content

Allow resources in Query::setParam #50268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2023
Merged

Allow resources in Query::setParam #50268

merged 1 commit into from
May 10, 2023

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented May 8, 2023 •
edited
Loading

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

See #46744 (comment)

(failures in tests seem not related)

@carsonbot carsonbot added this to the 6.3 milestone May 8, 2023
@l-vo l-vo changed the base branch from 6.3 to 5.4 May 8, 2023 19:33
@l-vo l-vo changed the base branch from 5.4 to 6.2 May 8, 2023 19:34
@l-vo l-vo requested a review from jderusse as a code owner May 8, 2023 19:34
@l-vo l-vo changed the base branch from 6.2 to 6.3 May 8, 2023 19:35
@l-vo l-vo force-pushed the allow_resources_setParam branch from 892f8d9 to 47081da Compare May 8, 2023 19:36
@l-vo l-vo changed the base branch from 6.3 to 6.2 May 8, 2023 19:36
@l-vo l-vo mentioned this pull request May 8, 2023
Merged
@l-vo l-vo force-pushed the allow_resources_setParam branch from 47081da to 318e0e4 Compare May 8, 2023 20:05
@l-vo l-vo mentioned this pull request May 8, 2023
Closed
@fabpot fabpot modified the milestones: 6.3, 6.2 May 10, 2023
@fabpot
Copy link
Member

fabpot commented May 10, 2023

Thank you @l-vo.

@fabpot fabpot merged commit 3cefdcb into symfony:6.2 May 10, 2023
fabpot added a commit that referenced this pull request May 10, 2023
@fabpot
bug #50269 Fix param type annotation (l-vo)
22edd15 
This PR was merged into the 5.4 branch.

Discussion
----------

Fix param type annotation

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

See #50268

Commits
-------

b0ec0c7 Fix param type annotation
@fabpot fabpot mentioned this pull request May 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@xabbuh xabbuh Awaiting requested review from xabbuh

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@l-vo @fabpot @stof @carsonbot