Skip to content

[Messenger] Add IS_REPEATABLE flag to AsMessageHandler attribute #50277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adrolter
Copy link
Contributor

@adrolter adrolter commented May 9, 2023

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50267
License MIT
Doc PR N/A

Allows repeating the AsMessageHandler attribute to support the preexisting behavior of the now-deprecated MessageSubscriberInterface.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@adrolter adrolter changed the base branch from 6.3 to 6.2 May 9, 2023 15:10
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.2 May 12, 2023
@nicolas-grekas
Copy link
Member

Thank you @adrianguenter.

@nicolas-grekas nicolas-grekas merged commit 38f71b0 into symfony:6.2 May 12, 2023
@adrolter adrolter deleted the repeatable_asmessagehandler_50267 branch May 12, 2023 22:21
@fabpot fabpot mentioned this pull request May 13, 2023
@fabpot fabpot mentioned this pull request May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants