Skip to content

[Mailer] [Sendinblue] refacto sendinblue to brevo #50279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Mailer] [Sendinblue] refacto sendinblue to brevo #50279

wants to merge 2 commits into from

Conversation

PEtanguy
Copy link
Contributor

@PEtanguy PEtanguy commented May 9, 2023 •
edited
Loading

WIP: I will make a new bridge altogether.

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR TODO

Hello,

This PR is aimed at updating the config for the sendinblue mailer.
As you might have seen, Sendinblue has rebranded to Brevo and also rewrote their apis.
This change ensure compatibility with the new endpoints and removes any reference to Sendinblue.

I do not think that this change qualifies as a feature but I also do not believe that it is a bug fix.

Please let me know if that does not fit in 6.3

@PEtanguy PEtanguy requested a review from OskarStark as a code owner May 9, 2023 22:49
@carsonbot carsonbot added this to the 6.3 milestone May 9, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark
Copy link
Contributor

From a code perspective we should introduce this as a new bridge and deprecate the sendinblue bridge. AFAIK we had a bridge which was "renamed" in the past, not sure yet how we did in this case.

@fabpot please leave your 2 cents here, thanks

@fabpot
Copy link
Member

fabpot commented May 10, 2023

From a code perspective we should introduce this as a new bridge and deprecate the sendinblue bridge. AFAIK we had a bridge which was "renamed" in the past, not sure yet how we did in this case.

@fabpot please leave your 2 cents here, thanks

That's correct.

@PEtanguy
Copy link
Contributor Author

@fabpot @OskarStark that's what I was wondering.

I will have a go at it, thanks.

@PEtanguy PEtanguy marked this pull request as draft May 10, 2023 08:36
@PEtanguy
Copy link
Contributor Author

I opened 2 new PRs to add a new notifier and a new mailer

#50296

@PEtanguy PEtanguy closed this May 10, 2023
@PEtanguy PEtanguy deleted the refacto_sendinblue_to_brevo branch May 10, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Mailer Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@PEtanguy @carsonbot @OskarStark @fabpot