[AssetMapper] Adding "excluded_patterns" option #50291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9eb814 to
2513ba7
Compare
fabpot
reviewed
May 12, 2023
fabpot
approved these changes
May 12, 2023
6666759 to
1c5a1e0
Compare
|
Thank you @weaverryan. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Invariably, some people will use AssetMapper with certain files that will need to be "built". Examples might be:
A) An
assets/app.cssthat uses Tailwind, and the user builds this manually toassets/build/app.cssand includes that file in their pipeline. The sourceassets/app.cssshould not be published topublic/assets.B) Similar with SCSS - e.g. all
*.scssmight be ignored because you are building them yourself.The new
excluded_patternsis a glob, for simplicity, and must match the entire file path - hence examples like*/assets/*.scssCheers!