[Notifier] Add Brevo bridge (formerly Sendinblue) #50296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
stof
reviewed
May 10, 2023
9a467e7 to
9622d22
Compare
|
@PEtanguy are you also working on the mailer bridge ? |
|
@stof yes i am waiting to merge this PR to open the Mailer one. The tests are failing because of the deprecation trigger |
|
You need to mark tests as And maybe the deprecation need to be triggered only if the factory is actually used instead of triggering it as soon as it is autoloaded, in case FrameworkBundle registers all installed factories. |
94noni
reviewed
May 11, 2023
| 6.3 | ||
| --- | ||
|
|
||
| * Added the bridge |
There was a problem hiding this comment.
should you mentioned that this is the replacement of https://packagist.org/packages/symfony/sendinblue-notifier?
and also in the other composer, mark it as deprecated?
3adf0d1 to
ae9867b
Compare
c90b1cf to
b4dcd18
Compare
OskarStark
reviewed
May 24, 2023
| private string $apiKey; | ||
| private string $sender; | ||
|
|
||
| public function __construct(#[\SensitiveParameter] string $apiKey, string $sender, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null) |
There was a problem hiding this comment.
We can use constructor property promotion for apiKey and sender
OskarStark
reviewed
May 24, 2023
OskarStark
reviewed
May 24, 2023
f079a58 to
6746d3c
Compare
6746d3c to
6cb3054
Compare
OskarStark
reviewed
Jun 14, 2023
| 6.4 | ||
| --- | ||
|
|
||
| * Added the bridge |
There was a problem hiding this comment.
Suggested change
| * Added the bridge | |
| * Add the bridge |
We can add an info about a replacement in the README; no need for it in the changeling file. From a code POV this is simply a new bridge
OskarStark
reviewed
Jun 14, 2023
| @@ -0,0 +1,25 @@ | |||
| Brevo Notifier | |||
| =================== | |||
There was a problem hiding this comment.
Suggested change
| =================== | |
| ============== |
OskarStark
reviewed
Jun 14, 2023
| @@ -0,0 +1,25 @@ | |||
| Brevo Notifier | |||
| =================== | |||
|
|
|||
There was a problem hiding this comment.
A note about the renaming can be put here
OskarStark
reviewed
Jun 14, 2023
| { | ||
| "name": "symfony/brevo-notifier", | ||
| "type": "symfony-notifier-bridge", | ||
| "description": "Symfony Brevo Notifier Bridge - formerly Sendinblue", |
There was a problem hiding this comment.
Suggested change
| "description": "Symfony Brevo Notifier Bridge - formerly Sendinblue", | |
| "description": "Symfony Brevo Notifier Bridge", |
OskarStark
reviewed
Jun 14, 2023
| "require": { | ||
| "php": ">=8.1", | ||
| "symfony/http-client": "^5.4|^6.0", | ||
| "symfony/notifier": "^6.3" |
There was a problem hiding this comment.
Suggested change
| "symfony/notifier": "^6.3" | |
| "symfony/notifier": "^6.4" |
OskarStark
requested changes
Jun 14, 2023
fabpot
approved these changes
Jul 9, 2023
3053f74 to
731f9b0
Compare
|
Thank you @PEtanguy. |
fabpot
added a commit
that referenced
this pull request
Jul 9, 2023
… (PEtanguy) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Mailer] New Brevo mailer bridge (formerly Sendinblue) | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | TODO Hello, This PR is aimed at updating the config for the sendinblue mailer. As you might have seen, Sendinblue has rebranded to [Brevo](https://developers.brevo.com/) and also rewrote their apis. This change ensure compatibility with the new endpoints and removes any reference to Sendinblue. This is the notifier PR: #50296 Commits ------- f537358 [Mailer] New Brevo mailer bridge (formerly Sendinblue)
symfony-splitter
pushed a commit
to symfony/mailer
that referenced
this pull request
Jul 9, 2023
… (PEtanguy) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Mailer] New Brevo mailer bridge (formerly Sendinblue) | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | TODO Hello, This PR is aimed at updating the config for the sendinblue mailer. As you might have seen, Sendinblue has rebranded to [Brevo](https://developers.brevo.com/) and also rewrote their apis. This change ensure compatibility with the new endpoints and removes any reference to Sendinblue. This is the notifier PR: symfony/symfony#50296 Commits ------- f537358e5a [Mailer] New Brevo mailer bridge (formerly Sendinblue)
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jul 9, 2023
… (PEtanguy) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Mailer] New Brevo mailer bridge (formerly Sendinblue) | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | TODO Hello, This PR is aimed at updating the config for the sendinblue mailer. As you might have seen, Sendinblue has rebranded to [Brevo](https://developers.brevo.com/) and also rewrote their apis. This change ensure compatibility with the new endpoints and removes any reference to Sendinblue. This is the notifier PR: symfony/symfony#50296 Commits ------- f537358e5a [Mailer] New Brevo mailer bridge (formerly Sendinblue)
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jul 28, 2023
… (PEtanguy) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Mailer] New Brevo mailer bridge (formerly Sendinblue) | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | TODO Hello, This PR is aimed at updating the config for the sendinblue mailer. As you might have seen, Sendinblue has rebranded to [Brevo](https://developers.brevo.com/) and also rewrote their apis. This change ensure compatibility with the new endpoints and removes any reference to Sendinblue. This is the notifier PR: symfony/symfony#50296 Commits ------- f537358e5a [Mailer] New Brevo mailer bridge (formerly Sendinblue)
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is aimed at updating the config for the sendinblue notifier.
As you might have seen, Sendinblue has rebranded to Brevo and also rewrote their apis.
This change ensure compatibility with the new endpoints and removes any reference to Sendinblue.
This is the mailer PR: #50302