Skip to content

[AssetMapper] Improving XSD to use attributes whenever possible #50307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2023
Merged

[AssetMapper] Improving XSD to use attributes whenever possible #50307

merged 1 commit into from
May 12, 2023

Conversation

weaverryan
Copy link
Member

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets None
License MIT
Doc PR TODO

Some notes from @stof - I was using <elements> for scalar config that works much better as attributes.

Cheers!

@carsonbot carsonbot added this to the 6.3 milestone May 12, 2023
@nicolas-grekas
Copy link
Member

Thank you @weaverryan.

@nicolas-grekas nicolas-grekas merged commit 3fcf300 into symfony:6.3 May 12, 2023
@weaverryan weaverryan deleted the asset-mapper-xsd-improvements branch May 12, 2023 17:54
@fabpot fabpot mentioned this pull request May 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@weaverryan @nicolas-grekas @stof @carsonbot