[Security] Skip clearing CSRF Token on stateless logout #50312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
May 13, 2023
| @@ -31,6 +32,10 @@ public function __construct(ClearableTokenStorageInterface $csrfTokenStorage) | |||
|
|
|||
| public function onLogout(LogoutEvent $event): void | |||
| { | |||
| if ($this->csrfTokenStorage instanceof SessionTokenStorage && !$event->getRequest()->hasPreviousSession()) { | |||
There was a problem hiding this comment.
What about fixing it in SessionTokenStorage instead?
There was a problem hiding this comment.
Using SessionTokenStorage without a session has been deprecated in 5.x:
Ideally this listener shouldn't be registered for stateless firewalls, problem is that it's not a per-firewall listener but a global one. We should probably change that in another (feature) PR.
|
Any way to test this? |
|
Thank you @chalasr. |
Sure, at least something preventing regressions. I'll do! |
chalasr
added a commit
that referenced
this pull request
May 19, 2023
…tateless logout (chalasr) This PR was merged into the 6.2 branch. Discussion ---------- [Security] Test `CsrfTokenClearingLogoutListener` with stateless logout | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #50312 (comment) | License | MIT | Doc PR | - Commits ------- 099ba75 [Security] Test `CsrfTokenClearingLogoutListener` with stateless logout
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not targeting 5.4 LTS as the bug is only breaking on 6.3 although it does exist on prior versions.