[FrameworkBundle][PropertyInfo] Wire the ConstructorExtractor class
#50334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a50e8c9 to
5261db6
Compare
5261db6 to
b68f40e
Compare
b68f40e to
711cbbd
Compare
da9d4fb to
03922ec
Compare
03922ec to
a02c6f1
Compare
a02c6f1 to
796dcc2
Compare
|
What is the status of this PR ? It would be nice to see this in 7.1. |
796dcc2 to
d2fcfbc
Compare
d2fcfbc to
c17cfc3
Compare
stof
reviewed
Oct 14, 2024
src/Symfony/Component/PropertyInfo/Extractor/ConstructorArgumentTypeExtractorInterface.php
Show resolved
Hide resolved
|
What about directly deprecating this option, so that it needs to be set on 8.0? Or defaulting it to true in 8.0? |
c17cfc3 to
31ef132
Compare
I'm ok with whatever is decided. |
mtarld
reviewed
Oct 25, 2024
| ->children() | ||
| ->booleanNode('with_constructor_extractor') | ||
| ->info('Registers the constructor extractor.') | ||
| ->defaultFalse() |
There was a problem hiding this comment.
I wouldn't have added any defaults here. Indeed, in that way, we could be able to raise a deprecation message in FrameworkExtension telling that with_constructor_extractor must be explicitly set, as its default value will change in 8.0.
If we're doing so, we must update the recipe so that it sets the with_constructor_extractor value to true for new 7.3 projects.
15c9261 to
f50586a
Compare
mtarld
reviewed
Jan 6, 2025
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
f50586a to
2b392b1
Compare
mtarld
approved these changes
Jan 6, 2025
|
Thank you @HypeMC. |
fabpot
added a commit
that referenced
this pull request
Jan 17, 2025
…peMC) This PR was merged into the 7.3 branch. Discussion ---------- [PropertyInfo] Move aliases under service definition | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follow-up to #50334, the aliases are normally defined right after the service. Commits ------- 22feb79 [PropertyInfo] Move aliases under service definition
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sort of followup to #30335.
The original PR removed the wiring to prevent creating a BC break, see #30128 (comment) & #30335 (comment).
This PR proposes adding a new
framework.property_info.with_constructor_extractorconfiguration to allow optionally enabling the framework integration. The configuration defaults tofalseto prevent creating a BC break. Only when it's set totruewill theConstructorExtractorbe registered in the container.