Skip to content

[WebProfilerBundle] Fix cursor on link that has no href #50386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023

Conversation

PhilETaylor
Copy link
Contributor

[WebProfilerBundle] Fix cursor on link that has no href

link to button

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no

Alternative approach for #50376

@stof @nicolas-grekas

@carsonbot carsonbot added this to the 6.3 milestone May 22, 2023
@PhilETaylor PhilETaylor changed the title Convert link to a button [WebProfilerBundle] Fix cursor on link that has no href May 22, 2023
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. can you please rebase to get ird of the merge commit?

@PhilETaylor
Copy link
Contributor Author

I screwed up with rebase so I redid and force pushed, is that ok?

Note the change at the end of profiler.css.twig is correct, as it cleans up one of the 2 blank lines at the end of the file

@carsonbot carsonbot changed the title [WebProfilerBundle] Fix cursor on link that has no href Fix cursor on link that has no href May 22, 2023
@PhilETaylor
Copy link
Contributor Author

using .btn-link now:

Screen.Recording.2023-05-22.at.18.08.14.mov

@carsonbot carsonbot changed the title Fix cursor on link that has no href [WebProfilerBundle] Fix cursor on link that has no href May 23, 2023
@nicolas-grekas
Copy link
Member

Thank you @PhilETaylor.

@nicolas-grekas nicolas-grekas merged commit 5bf5c4d into symfony:6.3 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants