[Cache] Redis garbage collector #50423
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
|
@zoidbergx it looks like you merged your non-rebased remote branch instead of forcing the push after the rebase was done, which means your PR contains duplicate commits in its history and a merge commit. |
src/Symfony/Component/Cache/Adapter/AbstractTagAwareAdapter.php
Outdated
Show resolved
Hide resolved
|
|
3f85db9 to
88258e4
Compare
|
@stof > yeah, for me it was a little bit of both as the current implementation could lead into a buggy cache but it may be more like a feature to have a garbage collector for Redis |
88258e4 to
fd3cfe5
Compare
src/Symfony/Component/Cache/Adapter/AbstractTagAwareAdapter.php
Outdated
Show resolved
Hide resolved
apply suggestion Co-authored-by: Alexander M. Turek <me@derrabus.de>
| local tagPrefix = string.gsub(KEYS[1], prefix, "") | ||
| return redis.call('SCAN', cursor, 'COUNT', 5000, 'MATCH', '*' .. tagPrefix .. '*', 'TYPE', 'set') | ||
| EOLUA; | ||
| $cursor = null; |
There was a problem hiding this comment.
This should be 0, null leads to something like: ERR invalid cursor script: 5880028e0d564320af1c1aabb595c9985f5a1a04, on @user_script:5.
This is used in SCAN which expects 0 to start and returns 0 when the iteration is finished: https://redis.io/docs/latest/commands/scan/
Unfortunately I can't find older docs and have to assume this is backward compatible.
| // cache items. | ||
| foreach ($tagKeys as $tagKey) { | ||
| $tagKey = substr($tagKey, \strlen($prefix)); | ||
| $cursor = null; |
There was a problem hiding this comment.
This should be 0, null leads to something like: ERR invalid cursor script: 5880028e0d564320af1c1aabb595c9985f5a1a04, on @user_script:5.
This is used in SCAN which expects 0 to start and returns 0 when the iteration is finished: https://redis.io/docs/latest/commands/scan/
Unfortunately I can't find older docs and have to assume this is backward compatible.
added a garbage collector for Redis to remove Tags which have no references, see #47835 for further details