[HttpKernel] Add special header to customize Response StatusCode in Error context #5043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has been thrown. This is useful as HttpKernel set response statuscode to 500 by default if the exception do not implement HttpExceptionInterface.
| @@ -201,7 +201,7 @@ private function handleException(\Exception $e, $request, $type) | |||
| $response->setStatusCode($e->getStatusCode()); | |||
| $response->headers->add($e->getHeaders()); | |||
| } else { | |||
| $response->setStatusCode(500); | |||
| $response->setStatusCode($response->headers->get(HttpKernelInterface::HEADER_STATUSCODE, 500)); | |||
There was a problem hiding this comment.
shouldn't you remove the header after that ?
There was a problem hiding this comment.
that's correct, I fixed it in the filterResponse method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT
As described here fabpot/Silex#438
Add special header to customize Response StatusCode when an exception has been thrown.
This is useful as HttpKernel set response statuscode to 500 by default if the exception do not implement HttpExceptionInterface.
See test for example