[FrameworkBundle] Fix debug:config & config:dump in debug mode
#50546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Jun 4, 2023
src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ConfigDebugCommandTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ConfigDumpReferenceCommandTest.php
Outdated
Show resolved
Hide resolved
73871a7 to
2824fc5
Compare
nicolas-grekas
approved these changes
Jun 6, 2023
|
Thank you @HypeMC. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 8, 2023
…fig` & `config:dump` list view & completion (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] Show non-bundle extensions in `debug:config` & `config:dump` list view & completion | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up to #50546 (should be merged first), adds non-bundle extensions to `debug:config` & `config:dump` list views: ```php class Kernel extends BaseKernel implements ExtensionInterface, ConfigurationInterface { use MicroKernelTrait; protected function build(ContainerBuilder $container) { $container->registerExtension(new MyExtension()); } public function getAlias() { return 'kernel'; } // ... } ```  Commits ------- b31f700 [FrameworkBundle] Show non-bundle extensions in `debug:config` & `config:dump` list view & completion
This was referenced Jun 26, 2023
Merged
Merged
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displaying configs for extensions without a bundle using the
debug:config&config:dump-referencecommands works depending on whether debug istrueorfalse. The reason behind this is the following code:symfony/src/Symfony/Bundle/FrameworkBundle/Command/BuildDebugContainerTrait.php
Lines 42 to 60 in b4128fd
When debug is
truethe extensions are never loaded in the container, so the commands don't work.There are even tests for these cases but they are all executed with debug
false.This PR aims to make the commands work with both debug
true&false. Another problem is that these extensions are not visible in the list of available extensions and are not offered by the completion feature, but since those seem more like new features I've created a separate PR for 6.4: #50548