[DoctrineBridge] Kill DBAL 2 support #50571
Conversation
eaa0c92 to
f174043
Compare
src/Symfony/Bridge/Doctrine/DataCollector/DoctrineDataCollector.php
Outdated
Show resolved
Hide resolved
|
Can't we target 6.4? That'd be nicer to the community. |
You mean drop DBAL 2 in 6.4 already? We can, but I didn't want to cut off projects that still run on DBAL 2 (or at least support it) on a minor release. I cannot really tell what the impact of that change would be.
One could argue that giving the community an LTS for migrating away from a still very popular package would be nicer though. |
|
Well, older versions of DoctrineBundle don't work well with Symfony 6.3 anyway (for instance, the |
Yes! |
c991664 to
07d2b97
Compare
…latform` (derrabus) This PR was merged into the 5.4 branch. Discussion ---------- [DoctrineBridge][Messenger] Add test cases for `MariaDBPlatform` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Backport from #50571 | License | MIT | Doc PR | N/A This PR adds test cases specifically for DBAL's `MariaDBPlatform` class. DBAL 4 will change the inheritance hierarchy for MySQL-like platforms, so having those tests might safe us one fine day. Commits ------- 618de82 Add test cases for MariaDBPlatform
9eff782 to
7ed12d3
Compare
In our case, it leaves DBAL 2 projects pinned to a non-LTS Symfony branch. But well, they have been warned, right? I can work out a PR for 6.4 once #50576 and #50579 are done. We can continue the discussion there. |
…ystem (derrabus) This PR was merged into the 6.4 branch. Discussion ---------- [DoctrineBridge] Deprecate using the old DBAL logger system | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | yes | Tickets | Backport from #50571 | License | MIT | Doc PR | N/A Commits ------- a8f6243 Deprecate using the old DBAL logger system
This PR was merged into the 6.4 branch. Discussion ---------- [DoctrineBridge] Require ORM 2.15 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Backported from #50571 | License | MIT | Doc PR | N/A Commits ------- 37e9d60 Require ORM 2.15
|
I'm torn now. I'd fine either way, which means fine for 7.0 :) |
|
Thank you @derrabus. |
DBAL 2 is dead and buried. Let's remove code that we needed to maintain DBAL 2.
TODO:
ContainerAwareEventManager::getListeners()deprecation #50575