[DependencyInjection] Deprecate ContainerAwareInterface, ContainerAwareTrait and ContainerAwareLoader
#50615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
901e9c2 to
e7e734d
Compare
|
Thanks. We also need to scan the code base for all usages of both and adjust as needed. |
|
Should this be done in this PR? I thought this would be done in the 7.0 one. But I can have a look in this one if needed 🙂 |
|
That's always been our policy yes: ensure we don't trigger self-deprecation and that the code path that are going to be removed do trigger a notice before being removed. |
e7e734d to
cdfc941
Compare
cdfc941 to
431da6f
Compare
ContainerAwareInterface and ContainerAwareTraitContainerAwareInterface, ContainerAwareTrait and ContainerAwareLoader
4488e55 to
7178180
Compare
src/Symfony/Component/DependencyInjection/Tests/Fixtures/ContainerAwareDummy.php
Show resolved
Hide resolved
7178180 to
5da1f93
Compare
chalasr
requested changes
Jun 11, 2023
...omponent/HttpKernel/Tests/DependencyInjection/RegisterControllerArgumentLocatorsPassTest.php
Show resolved
Hide resolved
src/Symfony/Bridge/Doctrine/Tests/DataFixtures/ContainerAwareLoaderTest.php
Outdated
Show resolved
Hide resolved
5da1f93 to
910005a
Compare
src/Symfony/Bundle/FrameworkBundle/Controller/ControllerResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/ControllerServiceResolution/config.yml
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/ContainerAwareTraitTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/ContainerAwareTraitTest.php
Outdated
Show resolved
Hide resolved
910005a to
f4ef751
Compare
46c0dd7 to
d95e02e
Compare
d95e02e to
218e17f
Compare
nicolas-grekas
approved these changes
Jun 12, 2023
|
What is the upgrade path for apps/bundles using this interface/trait? eg: the DoctrineBundle for container-aware migrations. |
|
@Kocal we've implemented |
218e17f to
6ec72bb
Compare
ro0NL
reviewed
Jun 19, 2023
6ec72bb to
1300895
Compare
…AwareTrait` and `ContainerAwareLoader`
1300895 to
fc3c572
Compare
|
Thank you @alexandre-daubois. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 21, 2023
…ntainerAwareTrait` (alexandre-daubois) This PR was merged into the 6.4 branch. Discussion ---------- [HttpKernel] Deprecate `ContainerAwareInterface` and `ContainerAwareTrait` Related to symfony/symfony#50615 Fix #18440 Commits ------- abd50b7 [HttpKernel] Deprecate `ContainerAwareInterface` and `ContainerAwareTrait`
This was referenced Oct 21, 2023
Merged
Merged
This was referenced Mar 23, 2024
This was referenced Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #50578 (comment)