Skip to content

[Validator] Add the message option to the PasswordStrength constraint #50654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

[Validator] Add the message option to the PasswordStrength constraint #50654

merged 1 commit into from
Jun 21, 2023

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Jun 13, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50651
License MIT
Doc PR No need

@carsonbot carsonbot added this to the 6.4 milestone Jun 13, 2023
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jun 13, 2023 •
edited
Loading

Let's target 6.3, that's clearly something we forgot about.

@alexandre-daubois alexandre-daubois force-pushed the password-strenght-message branch from babe4af to 8e96a98 Compare June 13, 2023 20:43
@alexandre-daubois alexandre-daubois changed the base branch from 6.4 to 6.3 June 13, 2023 20:43
@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Jun 13, 2023 •
edited
Loading

That's rebased on 6.3

Should the parameter be placed in second or third position while at it, to keep consistency between constraints?

@alexandre-daubois alexandre-daubois force-pushed the password-strenght-message branch from 8e96a98 to 2eed59d Compare June 13, 2023 20:45
nicolas-grekas
nicolas-grekas approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the parameter be placed in second or third position while at it, to keep consistency between constraints?

That'd be a BC break, + it's not needed with named args.

@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 6.3 Jun 21, 2023
@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit ddd38a0 into symfony:6.3 Jun 21, 2023
@fabpot fabpot mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
Feature Status: Reviewed Validator
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

Message parameter not exists in PasswordStrength constraint attribute
3 participants
@alexandre-daubois @nicolas-grekas @carsonbot