[DependencyInjection] Improve reporting named autowiring aliases #50718
+140
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 20, 2023
|
|
||
| public function __construct(string $name) | ||
| public function getParsedName(): string |
There was a problem hiding this comment.
should we even have it as a public method if calling it directly would be a mistake ?
There was a problem hiding this comment.
I think yes. Calling it directly works, but only if you gave a name to the constructor.
d1abfdb to
741a50c
Compare
|
i like the feature a lot. Thanks |
741a50c to
8d60a7e
Compare
fabpot
approved these changes
Jul 13, 2023
|
Thank you @nicolas-grekas. |
This was referenced Oct 21, 2023
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 1, 2023
… that contain underscores (nicolas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [DependencyInjection] Fix parsing named autowiring aliases that contain underscores | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52815 | License | MIT Fixing a regression introduced in #50718 Commits ------- 69a115c [DependencyInjection] Fix parsing named autowiring aliases that contain underscores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started as a fix of #48707 to improve the error message reported when
#[Target]is used with an invalid target, and ended up with many other related improvements:Allow using
#[Target]with no arguments. This has the effect of throwing an exception if the name of the argument that has the attribute doesn't match a named autowiring alias.Improve the error message when a target doesn't match:
debug:autowiringto display the target name to use with#[Target]: