[Serializer] Fix type error not be accessed before initialization #50776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fail to see how the error can actually happen as this property is initialised inside the constructor. |
|
I guess it can happen when the constructor is not called by a child class. Which child class are we talking about? Isn't this an issue with the child class? |
|
I think the problem comes from old cache items, without null on the typed property it gets to uninitialized. Always hard to add types to serialised objects 😅 . We have no class in Shopware which extends that class |
nicolas-grekas
approved these changes
Jun 26, 2023
|
Thank you @shyim. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the property like in Symfony 6.2, with 6.3 it got the type hint but the default value was missing