[EventDispatcher] Improve method resolving when it is omitted in tag #50783
+125
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php
Outdated
Show resolved
Hide resolved
f2bcee9 to
d2ebe37
Compare
d2ebe37 to
dcefe70
Compare
stof
reviewed
Aug 29, 2024
| foreach ($publicMethods as $publicMethod) { | ||
| if ( | ||
| !$publicMethod->isStatic() | ||
| && 1 === $publicMethod->getNumberOfRequiredParameters() |
There was a problem hiding this comment.
This check is bad given that the EventDispatcher component actually provides 3 parameters to listeners:
- the event object
- the event name
- the EventDispatcher instance
|
@nikophil any chance you handle the remaining comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this PR is a split of #50775)
this PR proposes to improve the listener's method resolution by:
someMethod()as the listener's method).__invokemethod exist we'll use this one without checking its parameters (this is also useful for BC)ping @GromNaN
(CI failures seems unrelated to this PR 🤔 )