[SecurityBundle] Do not translate Bearer header’s error_description
#50819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Jun 29, 2023
src/Symfony/Component/Security/Http/Authenticator/AccessTokenAuthenticator.php
Outdated
Show resolved
Hide resolved
Bearer header’s error_descriptionBearer header’s error_description
nicolas-grekas
approved these changes
Jun 29, 2023
derrabus
approved these changes
Jun 29, 2023
Bearer header’s error_descriptionBearer header’s error_description
06e0b16 to
cde0af3
Compare
|
Thank you @MatTheCat. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From RFC 6750:
Not translating it avoids non-ASCII characters in
Bearer’s value, which in turn avoid messing with RFC 8187 (fun read; thanks @derrabus!).Not sure if and how this should be tested 🤔