Skip to content

[Doctrine][Serializer] Remove ExpectDeprecationTrait where it is not used #50829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jun 30, 2023

Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR n/a

This unused code has been left by #50558 and #50575.

I think PHPStan should detect when the trait is imported but the method expectDeprecation is not used.

Other PR for 6.4 #50828

@GromNaN GromNaN requested a review from dunglas as a code owner June 30, 2023 01:28
@carsonbot carsonbot added this to the 7.0 milestone Jun 30, 2023
@carsonbot carsonbot changed the title Remove ExpectDeprecationTrait where it is not used [Doctrine][Serializer] Remove ExpectDeprecationTrait where it is not used Jun 30, 2023
@OskarStark OskarStark changed the title [Doctrine][Serializer] Remove ExpectDeprecationTrait where it is not used [Doctrine][Serializer] Remove ExpectDeprecationTrait where it is not used Jun 30, 2023
@nicolas-grekas
Copy link
Member

Thank you @GromNaN.

@nicolas-grekas nicolas-grekas merged commit b08e1b9 into symfony:7.0 Jun 30, 2023
@GromNaN GromNaN deleted the remove-unused-deprecation-trait branch June 30, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants